you are digging a pit for yourself and you know it. If a guy has been to jail, unless he is remarkably disciplined and committed to achieving something else in his life- he will probably be there again., So if you stay with this guy , you will be exposing yourself to his
temperTemper tantrums, his inabilty to stay out of trouble , and his inability to take care of you in any way except sexually.
You are needy. You call him up when you are lonely- and he's available. It's not about him- it's about your
weaknessWeakness. I am not blaming you- most of us get lonely and make compromises to have someone by our side-- but this guy sounds like way too much of a compromise.
If he is worthy, he would stay out of trouble so that he could protect you and be a mature man, able to take care of himself and the people he loves. But this sounds unlikely-- and also your on and off feelings for him indicate a relationship that does not have enough going for it. Look at what you do- miss him only when he is missing!
You don't crave him when he is with you because he is not offering you enough.
Listen to your own instincts. Get out of this relationship and find one with a man who looks like he can make a future life that both of you will enjoy,.