Your son is taking quite a high dose of Concerta. There is no reason to expect that he will not continue to have suppressed appetite. It's not so much an issue of how long he has been on medication, but rather an issue of finding the best medication for him (i.e., the medication that proves to be clinically effective without untoward side effects). Stimulant medications (e.g., Concerta, Ritalin, Adderall, Metadate, etc.) all have the potential to suppress appetite. This in itself is not always a problem. It becomes a problem if it leads to persistent weight loss. Strattera is a treatment for ADHD that is not in the psychostimulant family of medications. It does not suppress appetite and is quite an effective medication, particularly for those children who are inattentive but not hyperactive.
I am not familiar with Cncerta dosage. You might ask the doctor if he thinks that 2 36mg pills are a high dosage. Have you tried a smaller dosage and see if it improves the side effects?
I'm still confused about how long is too long to be on this medication and will the weight loss adventually stop or at least slow down?
What is non-stimulant Strattera and how will it help my son?
My son takes two 36mg pills daily in the morning....
Is he taking 36mg plus 36 mg or 18mg plus 18mg?
Suppressed appetite is the most common side effect of stimulant medication, so it is not surprising that this is happening. Often with adolescents, because of the natural increase in growth, this is not a big problem. Such is not the case with your son. If he has not been tried on the non-stimulant Strattera it might be a good alternative to the Concerta.